linux-kernel - Re: [PATCH v2 0/3] LED triggers for USB host and device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK5ve-LY5+bTcBNYD72CEzGNontk+0D+y2cmtFu+pNkPNU9skA@mail.gmail.com>
Date:	Fri, 22 Aug 2014 17:23:38 -0700
From:	Bryan Wu <cooloney@...il.com>
To:	Michal Sojka <sojka@...ica.cz>
Cc:	linux-usb@...r.kernel.org, Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linux LED Subsystem <linux-leds@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>, michal.vokac@...ap.cz
Subject: Re: [PATCH v2 0/3] LED triggers for USB host and device

On Fri, Aug 22, 2014 at 5:08 PM, Michal Sojka <sojka@...ica.cz> wrote:
> This adds LED triggers for USB host and device.
>
> Changes from v1:
> - Moved from drivers/leds/ to drivers/usb/
> - Improved Kconfig help
> - Linked with other modules rather than being standalone modules
>
> Michal Sojka (3):
>   usb: Add missing #include
>   usb: Add LED trigger for USB host activity
>   usb: Add LED trigger for USB gadget activity
>
>  drivers/usb/core/Kconfig        |  9 +++++++++
>  drivers/usb/core/Makefile       |  1 +
>  drivers/usb/core/hcd.c          |  2 ++
>  drivers/usb/core/led.c          | 38 ++++++++++++++++++++++++++++++++++++++

I suggest put host trigger and gadget trigger together in
drivers/usb/core/led.c.

>  drivers/usb/gadget/Kconfig      | 12 ++++++++++++
>  drivers/usb/gadget/udc/Makefile |  5 ++++-
>  drivers/usb/gadget/udc/led.c    | 38 ++++++++++++++++++++++++++++++++++++++

We don't need a duplicated version for gadget.

>  drivers/usb/musb/musb_gadget.c  |  5 +++--
>  include/linux/usb/gadget.h      | 10 ++++++++++
>  include/linux/usb/hcd.h         |  7 +++++++
>  10 files changed, 124 insertions(+), 3 deletions(-)
>  create mode 100644 drivers/usb/core/led.c
>  create mode 100644 drivers/usb/gadget/udc/led.c
>
> --
> 2.1.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/