linux-kernel - Re: percpu: Define this_cpu_cpumask_var_t

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140823171416.GG13540@mtj.dyndns.org>
Date:	Sat, 23 Aug 2014 13:14:16 -0400
From:	Tejun Heo <htejun@...il.com>
To:	Christoph Lameter <cl@...ux.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Fengguang Wu <fengguang.wu@...el.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Motohiro Kosaki <Motohiro.Kosaki@...fujitsu.com>,
	Mike Travis <travis@....com>
Subject: Re: percpu: Define this_cpu_cpumask_var_t_ptr

Hello, Christoph.

On Fri, Aug 22, 2014 at 12:43:25PM -0500, Christoph Lameter wrote:
> It wont accept the wrong type since the this_cpu_* functions will do type
> checking.

It should only accept cpumask_var_t but the macro version accepts
anything that this_cpu_*() can handle.

> > > _t is there because I wanted to include the full "ugly" name of the
> > > variable to make it similarly ugly. It is needed to make the clear
> > > distinction to "struct cpumask *" which does not have these issues.
> >
> > The compiler can enforce that rule easily if the interface functions
> > are properly typed.  I think it'd be far better to go with properly
> > typed accessors with less unwieldy names.
> 
> What rule are we talking about? Accessors for what?

I meant that if the new accessors you're adding are proper inline
functions, the compiler would be able to verify the specific type they
should take.  IOW, let's go for shorter name w/ stricter type
checking.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/