linux-kernel - Re: Problem with commit: x86, iosf: Make IOSF driver modular and usable by more drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53F8D1FE.5050205@infradead.org>
Date:	Sat, 23 Aug 2014 10:40:14 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Fejes József <jozsef.fejes@...il.com>,
	linux-kernel@...r.kernel.org, linux-stable@...r.kernel.org,
	"David E. Box" <david.e.box@...ux.intel.com>
Subject: Re: Problem with commit: x86, iosf: Make IOSF driver modular and
 usable by more drivers

On 08/23/14 02:31, Fejes József wrote:
> Hi,
> 
> I think there's a problem with commit
> 6b8f0c8780c71d78624f736d7849645b64cc88b7: config IOSF_MBI is
> automatically a module and I cannot change that.
> 
> I've been using 3.15.* stable kernels. I have module support enabled,
> but I build everything into the kernel, so I don't actually have any
> modules built. I just upgraded to 3.16.1, and found out that I now
> have this one module. I cannot find it in the menu, so I edited the
> .config file by hand, but it changes back from =y to =m. Could you
> please look into fixing it, and push it to 3.16.* stable branch?

[adding David E. Box to email]

This is a mainline issue, not just a -stable issue.
Once fixed in mainline (if ever), then that fix can be added to -stable.

Fejes, you could just disable module support and then iosf_mbi would be built
into the kernel.  But as a loadable module, it won't waste memory if it's
not needed.

David, any other suggestions?
Why can't the users of IOSF_MBI just select it?  That's what many other
drivers do when they need to be sure that some functionality is present.

I'm surprised that someone else (e.g. Linus) has not complained about the
'default m' for this driver.

-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/