lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 23 Aug 2014 10:31:15 +0800 From: Chen Gang <gang.chen.5i5j@...il.com> To: Michal Marek <mmarek@...e.cz>, Geert Uytterhoeven <geert@...ux-m68k.org> CC: Arnd Bergmann <arnd@...db.de>, Andrew Morton <akpm@...ux-foundation.org>, Jean Delvare <jdelvare@...e.de>, Russell King <linux@....linux.org.uk>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will.deacon@....com>, Mark Salter <msalter@...hat.com>, "a-jacquiot@...com" <a-jacquiot@...com>, Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghua.yu@...el.com>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>, the arch/x86 maintainers <x86@...nel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, linux-c6x-dev@...ux-c6x.org, "linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Linux-Arch <linux-arch@...r.kernel.org>, linux-kbuild <linux-kbuild@...r.kernel.org> Subject: Re: [PATCH v2] arch: Kconfig: Let all little endian architectures define CPU_LITTLE_ENDIAN explicitly On 8/22/14 19:09, Michal Marek wrote: > Dne 13.8.2014 10:03, Geert Uytterhoeven napsal(a): >> CC kbuild >> >> On Wed, Aug 13, 2014 at 12:48 AM, Chen Gang <gang.chen.5i5j@...il.com> wrote: >>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >>> index c49a775..0510a5d 100644 >>> --- a/arch/arm/Kconfig >>> +++ b/arch/arm/Kconfig >>> @@ -199,6 +199,11 @@ config NEED_DMA_MAP_STATE >>> config ARCH_SUPPORTS_UPROBES >>> def_bool y >>> >>> +config CPU_LITTLE_ENDIAN >>> + depends on !CPU_BIG_ENDIAN >>> + def_bool y >>> + >>> + >>> config ARCH_HAS_DMA_SET_COHERENT_MASK >>> bool >> >> As this is a common symbol, and replicated for all affected architectures, >> I'm wondering if we should have the "config CPU_LITTLE_ENDIAN" in >> common Kconfig code instead, and make the individual architectures do a >> "select CPU_LITTLE_ENDIAN"? > > Yes! > > >> Also we could have "config CPU_BIG_ENDIAN", too, and error out >> if none or both are selected (can Kconfig error out?). > > We can error out in the Makefile, if there is consensus that we should > be doing so. > OK, thanks. I have sent patch v3 for it, and did not check related error in Kconfig files. Please check the related patches (excuse me, I send the patch v3 only according to "scripts/maintainers.pl", maybe not cc to you explicitly). Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists