linux-kernel - RE: [PATCH v3] scsi: ufs-msm: add UFS controller support for Qualcomm MSM chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <000601cfbfa2$7482f3a0$5d88dae0$@codeaurora.org>
Date:	Sun, 24 Aug 2014 16:51:00 +0300
From:	"Yaniv Gardi" <ygardi@...eaurora.org>
To:	"'Dan Aloni'" <dan@...nelim.com>
Cc:	<James.Bottomley@...senPartnership.com>, <hch@...radead.org>,
	<linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
	<linux-arm-msm@...r.kernel.org>, <santoshsy@...il.com>,
	<linux-scsi-owner@...r.kernel.org>, <subhashj@...eaurora.org>,
	<noag@...eaurora.org>, <draviv@...eaurora.org>,
	"'Rob Herring'" <robh+dt@...nel.org>,
	"'Pawel Moll'" <pawel.moll@....com>,
	"'Mark Rutland'" <mark.rutland@....com>,
	"'Ian Campbell'" <ijc+devicetree@...lion.org.uk>,
	"'Kumar Gala'" <galak@...eaurora.org>,
	"'Vinayak Holikatti'" <vinholikatti@...il.com>,
	"'James E.J. Bottomley'" <JBottomley@...allels.com>,
	"'Grant Likely'" <grant.likely@...aro.org>,
	"'Sujit Reddy Thumma'" <sthumma@...eaurora.org>,
	"'Sahitya Tummala'" <stummala@...eaurora.org>,
	"'open list:OPEN FIRMWARE AND...'" <devicetree@...r.kernel.org>
Subject: RE: [PATCH v3] scsi: ufs-msm: add UFS controller support for Qualcomm MSM chips

Thanks Dan,

Your quick glance did spotted a good catch. This variable if un-necessary,
A new version will be uploaded soon

Thanks,
Yaniv


-----Original Message-----
From: linux-scsi-owner@...r.kernel.org
[mailto:linux-scsi-owner@...r.kernel.org] On Behalf Of Dan Aloni
Sent: Saturday, August 16, 2014 8:33 PM
To: Yaniv Gardi
Cc: James.Bottomley@...senPartnership.com; hch@...radead.org;
linux-kernel@...r.kernel.org; linux-scsi@...r.kernel.org;
linux-arm-msm@...r.kernel.org; santoshsy@...il.com;
linux-scsi-owner@...r.kernel.org; subhashj@...eaurora.org;
noag@...eaurora.org; draviv@...eaurora.org; Rob Herring; Pawel Moll; Mark
Rutland; Ian Campbell; Kumar Gala; Vinayak Holikatti; James E.J. Bottomley;
Grant Likely; Sujit Reddy Thumma; Sahitya Tummala; open list:OPEN FIRMWARE
AND...
Subject: Re: [PATCH v3] scsi: ufs-msm: add UFS controller support for
Qualcomm MSM chips

On Thu, Aug 14, 2014 at 05:22:18PM +0300, Yaniv Gardi wrote:
> diff --git a/drivers/scsi/ufs/ufs-msm.h b/drivers/scsi/ufs/ufs-msm.h 
> new file mode 100644 index 0000000..6e93f1e
> --- /dev/null
> +++ b/drivers/scsi/ufs/ufs-msm.h
> @@ -0,0 +1,158 @@
[...]
> +};
> +
> +static LIST_HEAD(phy_list);
> +

Just noticed this via a quick glance - Seems that this variable is not
referenced by any of the compilation units, what's the purpose of it?
And as a static global in a shared private, each of the including
compilation units gets a copy, which I am not sure was intended anyway.

--
Dan Aloni
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the
body of a message to majordomo@...r.kernel.org More majordomo info at
http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/