linux-kernel - [PATCH V2] efi_high_alloc: use EFI_ALLOCATE_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1408967732-2381-1-git-send-email-harald@redhat.com>
Date:	Mon, 25 Aug 2014 13:55:32 +0200
From:	harald@...hat.com
To:	linux-kernel@...r.kernel.org
Cc:	linux-efi@...r.kernel.org, Harald Hoyer <harald@...hat.com>
Subject: [PATCH V2] efi_high_alloc: use EFI_ALLOCATE_MAX_ADDRESS

From: Harald Hoyer <harald@...hat.com>

On my Lenovo T420s with 4GB memory, efi_high_alloc() was checking the
following memory regions:

0x0000000000100000 - 0x0000000020000000
0x0000000020200000 - 0x0000000040000000
0x0000000040200000 - 0x00000000d2c02000
0x00000000d6e9f000 - 0x000000011e600000

and decided to allocate 2649 pages at address 0x11dba7000.
...
[    0.000000] efi: mem53: type=2, attr=0xf, range=[0x000000011dba7000-0x000000011e600000) (10MB)
...
[    0.000000] RAMDISK: [mem 0x11dba7000-0x11e5fffff]
...
[    0.154933] Unpacking initramfs...
[    0.160990] Initramfs unpacking failed: junk in compressed archive
[    0.163436] Freeing initrd memory: 10596K (ffff88011dba7000 - ffff88011e600000)
...

Nevertheless, unpacking of the initramfs later on failed.
This is maybe caused by my buggy EFI BIOS and
commit 4bf7111f50167133a71c23530ca852a41355e739,
which enables loading the initramfs above 4G addresses.

With this patch efi_high_alloc() now uses EFI_ALLOCATE_MAX_ADDRESS,
which should do the same as before, but use the EFI logic to select the high memory range.

This returns 0x00000000d2c02000 on my machine and the initramfs is
loaded, uncompressed and executed correctly.

...
[    0.000000] efi: mem15: type=2, attr=0xf, range=[0x00000000d2c02000-0x00000000d365b000) (10MB)
...
[    0.000000] RAMDISK: [mem 0xd2c02000-0xd365afff]
...
[    0.151269] Unpacking initramfs...
[    0.309868] Freeing initrd memory: 10596K (ffff8800d2c02000 - ffff8800d365b000)
...


Signed-off-by: Harald Hoyer <harald@...hat.com>
---

V2: return value of EFI_ALLOCATE_MAX_ADDRESS is the begin of the segment, and not the end

 drivers/firmware/efi/libstub/efi-stub-helper.c | 74 +++++---------------------
 1 file changed, 14 insertions(+), 60 deletions(-)

diff --git a/drivers/firmware/efi/libstub/efi-stub-helper.c b/drivers/firmware/efi/libstub/efi-stub-helper.c
index 32d5cca..9aafcf8 100644
--- a/drivers/firmware/efi/libstub/efi-stub-helper.c
+++ b/drivers/firmware/efi/libstub/efi-stub-helper.c
@@ -118,82 +118,36 @@ efi_status_t efi_high_alloc(efi_system_table_t *sys_table_arg,
 			    unsigned long size, unsigned long align,
 			    unsigned long *addr, unsigned long max)
 {
-	unsigned long map_size, desc_size;
-	efi_memory_desc_t *map;
 	efi_status_t status;
 	unsigned long nr_pages;
 	u64 max_addr = 0;
-	int i;
-
-	status = efi_get_memory_map(sys_table_arg, &map, &map_size, &desc_size,
-				    NULL, NULL);
-	if (status != EFI_SUCCESS)
-		goto fail;
 
 	/*
 	 * Enforce minimum alignment that EFI requires when requesting
-	 * a specific address.  We are doing page-based allocations,
+	 * a specific address.	We are doing page-based allocations,
 	 * so we must be aligned to a page.
 	 */
 	if (align < EFI_PAGE_SIZE)
 		align = EFI_PAGE_SIZE;
 
-	nr_pages = round_up(size, EFI_PAGE_SIZE) / EFI_PAGE_SIZE;
-again:
-	for (i = 0; i < map_size / desc_size; i++) {
-		efi_memory_desc_t *desc;
-		unsigned long m = (unsigned long)map;
-		u64 start, end;
-
-		desc = (efi_memory_desc_t *)(m + (i * desc_size));
-		if (desc->type != EFI_CONVENTIONAL_MEMORY)
-			continue;
-
-		if (desc->num_pages < nr_pages)
-			continue;
-
-		start = desc->phys_addr;
-		end = start + desc->num_pages * (1UL << EFI_PAGE_SHIFT);
-
-		if ((start + size) > end || (start + size) > max)
-			continue;
-
-		if (end - size > max)
-			end = max;
-
-		if (round_down(end - size, align) < start)
-			continue;
-
-		start = round_down(end - size, align);
-
-		/*
-		 * Don't allocate at 0x0. It will confuse code that
-		 * checks pointers against NULL.
-		 */
-		if (start == 0x0)
-			continue;
+	nr_pages = round_up(size, align) / EFI_PAGE_SIZE;
+	max_addr = round_down(round_down((max_addr-size), align) + size, EFI_PAGE_SIZE);
 
-		if (start > max_addr)
-			max_addr = start;
-	}
+	/*
+	 * In case align > EFI_PAGE_SIZE, we need a little more space,
+	 * to round_up() later
+	 */
+	if (align > EFI_PAGE_SIZE)
+		nr_pages += round_up(align, EFI_PAGE_SIZE) / EFI_PAGE_SIZE;
 
-	if (!max_addr)
-		status = EFI_NOT_FOUND;
-	else {
-		status = efi_call_early(allocate_pages,
-					EFI_ALLOCATE_ADDRESS, EFI_LOADER_DATA,
-					nr_pages, &max_addr);
-		if (status != EFI_SUCCESS) {
-			max = max_addr;
-			max_addr = 0;
-			goto again;
-		}
+	status = efi_call_early(allocate_pages,
+				EFI_ALLOCATE_MAX_ADDRESS, EFI_LOADER_DATA,
+				nr_pages, &max_addr);
 
-		*addr = max_addr;
+	if (status == EFI_SUCCESS) {
+		*addr = round_up(max_addr, align);
 	}
 
-	efi_call_early(free_pool, map);
-fail:
 	return status;
 }
 
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/