linux-kernel - Re: [RESEND PATCH] acpi-cpufreq: get the cur_freq from acpi_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Aug 2014 19:11:37 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Wang Weidong <wangweidong1@...wei.com>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org >> linux-kernel@...r.kernel.org" 
	<linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH] acpi-cpufreq: get the cur_freq from
 acpi_processor_performance states

On 21 August 2014 11:25, Wang Weidong <wangweidong1@...wei.com> wrote:
> As the initialized freq_tables maybe different from the p-states
> values, so the array index is different as well.
>
> p-states value: [2400 2400 2000 ...], while the freq_tables:
> [2400 2000 ... CPUFREQ_TABLE_END]. After setted the freqs 2000,
> the perf->state is 3 while the freqs_table's index should be 2.
> So when call the get_cur_freq_on_cpu, the freqs value we get
> is 2400.
>
> So, fix the problem with the correct tables.
>
> Signed-off-by: Wang Weidong <wangweidong1@...wei.com>
> ---
>  drivers/cpufreq/acpi-cpufreq.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index b0c18ed..ac93885 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -365,6 +365,7 @@ static u32 get_cur_val(const struct cpumask *mask)
>  static unsigned int get_cur_freq_on_cpu(unsigned int cpu)
>  {
>         struct acpi_cpufreq_data *data = per_cpu(acfreq_data, cpu);
> +       struct acpi_processor_performance *perf;
>         unsigned int freq;
>         unsigned int cached_freq;
>
> @@ -375,7 +376,8 @@ static unsigned int get_cur_freq_on_cpu(unsigned int cpu)
>                 return 0;
>         }
>
> -       cached_freq = data->freq_table[data->acpi_data->state].frequency;
> +       perf = data->acpi_data;
> +       cached_freq = perf->states[perf->state].core_frequency * 1000;
>         freq = extract_freq(get_cur_val(cpumask_of(cpu)), data);
>         if (freq != cached_freq) {
>                 /*

The problem looks real but I am not very well aware of this driver and
so it would
be more appropriate if Rafael replies/Applies..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/