linux-kernel - Re: [RFC 00/10] perf pollfd series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140825155613.GA2849@kernel.org>
Date:	Mon, 25 Aug 2014 12:56:13 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Adrian Hunter <adrian.hunter@...el.com>,
	Borislav Petkov <bp@...e.de>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	David Ahern <dsahern@...il.com>,
	Don Zickus <dzickus@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Jean Pihet <jean.pihet@...aro.org>,
	Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [RFC 00/10] perf pollfd series

Em Mon, Aug 25, 2014 at 01:04:31PM +0200, Jiri Olsa escreveu:
> fdarray name seems too generic for this object, fdpoll looks
> more suitable.. also given that the file name is poll.[ch] ;-)

I thought about 'struct pollfds', then thought that having 'poll' in the
name of the class and in its main routine, i.e. pollfds__poll, would be
too much.

I thought of it as an extensible array of file descriptors that right
now has just poll related operations, but could have some other
operations, perhaps the associated mmaps in evlist, for instance.

I ended up using poll.[ch] because struct pollfd came from poll.h, but
yeah, that is inconsistent with poll being just one of the operations
for an extensible array of file descriptors, so it should be renamed
accordingly to 'fdarray.[ch]'.

That was my reasoning.

I'm looking at the other comments, would send a fix for what Adrian
commented but thought about an optimization, will do that after lunch,
hopefully food will prevent me from adding more bugs 8-)

> anyway, except for what I've already commented:

> Acked-by: Jiri Olsa <jolsa@...nel.org>

Thanks!

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/