linux-kernel - Re: [PATCH v2] ioat: Use pci_enable_msix_exact() instead of pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140825163518.GB5853@agordeev.usersys.redhat.com>
Date:	Mon, 25 Aug 2014 17:35:19 +0100
From:	Alexander Gordeev <agordeev@...hat.com>
To:	Dan Williams <dan.j.williams@...el.com>,
	Vinod Koul <vinod.koul@...el.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Vinod Koul <vinod.koul@...el.com>,
	"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH v2] ioat: Use pci_enable_msix_exact() instead of
 pci_enable_msix()

On Fri, Mar 07, 2014 at 08:49:32AM +0100, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range()  or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.

Dan, Vinod,

This patch hangs in -next for quite some time.
Would you release it, please?

Thanks!

> Function pci_enable_msix() returns a tri-state value while
> pci_enable_msi_exact() is a canonical zero/-errno variant.
> The former is being phased out in favor of the latter.
> In case of 'ioat' there (should be) no difference.
> 
> Signed-off-by: Alexander Gordeev <agordeev@...hat.com>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Vinod Koul <vinod.koul@...el.com>
> Cc: dmaengine@...r.kernel.org
> Cc: linux-pci@...r.kernel.org
> Acked-by: Dan Williams <dan.j.williams@...el.com>
> ---
>  drivers/dma/ioat/dma.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
> index 4e3549a..b76c148 100644
> --- a/drivers/dma/ioat/dma.c
> +++ b/drivers/dma/ioat/dma.c
> @@ -947,7 +947,7 @@ msix:
>  	for (i = 0; i < msixcnt; i++)
>  		device->msix_entries[i].entry = i;
>  
> -	err = pci_enable_msix(pdev, device->msix_entries, msixcnt);
> +	err = pci_enable_msix_exact(pdev, device->msix_entries, msixcnt);
>  	if (err)
>  		goto msi;
>  
> -- 
> 1.7.7.6
> 
> -- 
> Regards,
> Alexander Gordeev
> agordeev@...hat.com

-- 
Regards,
Alexander Gordeev
agordeev@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/