linux-kernel - Re: [PATCH] tpm: fix interrupt timeouts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Aug 2014 12:03:45 -0600
From:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:	Scot Doyle <lkml14@...tdoyle.com>
Cc:	Peter Huewe <peterhuewe@....de>, Ashley Lai <ashley@...leylai.com>,
	Marcel Selhorst <tpmdd@...horst.net>,
	Stefan Berger <stefanb@...ux.vnet.ibm.com>,
	Luigi Semenzato <semenzato@...gle.com>,
	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tpm: fix interrupt timeouts

On Mon, Aug 25, 2014 at 07:14:03AM +0000, Scot Doyle wrote:
> commit 4c663cfc523a88d97a8309b04a089c27dc57fd7e
>     wait: fix false timeouts when using wait_event_timeout()
> 
> changed the semantics of wait_event_interruptible_timeout so that a
> condition check is performed after timeout and 1 is returned if true.
> 
> The TPM chip may not send interrupts even though the tpm module is
> attempting to receive interrupts. In this case, after the module
> sends a command to the TPM chip it performs a blocking wait on the
> interrupt queue. No interrupts are sent from the chip, the queue is
> not woken up and the blocking wait times out. Despite timing out,
> the command has completed and the condition check performed by
> wait_event_interruptible_timeout after timeout is true, resulting in
> a return value of 1. Since the expected return value on timeout is 0
> the timeout is not detected.
> 
> To fix, assume a return value of 1 or less indicates an elapsed
> timeout. It is possible for the return value to be 1 after receiving
> an interrupt, but this should be rare. The condition is not double-
> checked because of possible side effects.

Hum.. Okay, so I see what you are trying to fix here, but the code is
actually using wait_event_interruptible_timeout correctly as is. 

The TPM actually did complete the operation, and the test sentinal
checks directly at the TPM - which makes sense to me..

I think you'll have to directly test in the tis driver if the
interrupt is working.

The ordering in the TIS driver is wrong, interrupts should be turned
on before any TPM commands are issued. This is what other drivers are
doing.
	
If you fix this, tis can then just count interrupts recieved and check
if that is 0 to detect failure and then turn them off.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/