linux-kernel - Re: [PATCH 11/19] iwl4965: fix %d confusingly prefixed with 0x in format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140825201801.GH1966@tuxdriver.com>
Date:	Mon, 25 Aug 2014 16:18:01 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Hans Wennborg <hans@...shq.net>
Cc:	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/19] iwl4965: fix %d confusingly prefixed with 0x in
 format string

On Sun, Aug 03, 2014 at 05:20:05PM -0700, Hans Wennborg wrote:
> Signed-off-by: Hans Wennborg <hans@...shq.net>
> ---
>  drivers/net/wireless/iwlegacy/4965-mac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
> index c159c05..7d6fd59 100644
> --- a/drivers/net/wireless/iwlegacy/4965-mac.c
> +++ b/drivers/net/wireless/iwlegacy/4965-mac.c
> @@ -4633,7 +4633,7 @@ il4965_store_tx_power(struct device *d, struct device_attribute *attr,
>  	else {
>  		ret = il_set_tx_power(il, val, false);
>  		if (ret)
> -			IL_ERR("failed setting tx power (0x%d).\n", ret);
> +			IL_ERR("failed setting tx power (0x%x).\n", ret);
>  		else
>  			ret = count;
>  	}

It seems like that should be "0x%08x" or similar, no?

-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/