linux-kernel - Re: [PATCH v2] nfs: remove redundant slash from nfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1409000826.3033.32.camel@deadeye.wl.decadent.org.uk>
Date:	Mon, 25 Aug 2014 14:07:06 -0700
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Xiong Zhou <xzhou@...hat.com>
Cc:	trond myklebust <trond.myklebust@...marydata.com>,
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] nfs: remove redundant slash from nfs_path

On Mon, 2014-08-25 at 01:51 -0400, Xiong Zhou wrote:
> When export root dir(/) via nfs, and mount a particular dir under root, eg
> /nfsexport, there will be defect double slash output in /proc/mounts, like
> localhost://nfsexport. While this patch change it to localhost:/nfsexport.
> 
> Signed-off-by: Xiong Zhou <xzhou@...hat.com>
> ---
>  fs/nfs/namespace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/namespace.c b/fs/nfs/namespace.c
> index b5a0afc..24f954e 100644
> --- a/fs/nfs/namespace.c
> +++ b/fs/nfs/namespace.c
> @@ -98,7 +98,7 @@ rename_retry:
>  		return end;
>  	}
>  	namelen = strlen(base);
> -	if (flags & NFS_PATH_CANONICAL) {
> +	if ((flags & NFS_PATH_CANONICAL) || *end == '/') {
>  		/* Strip off excess slashes in base string */
>  		while (namelen > 0 && base[namelen - 1] == '/')
>  			namelen--;

I think this makes sense, though I'm not sure I completely understand
this function. :-/

Ben.

-- 
Ben Hutchings
All extremists should be taken out and shot.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)