linux-kernel - Re: PROBLEM: bindings for drivers/mfd/twl4030-power.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140825212652.GR17254@atomide.com>
Date:	Mon, 25 Aug 2014 14:26:54 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	"Dr. H. Nikolaus Schaller" <hns@...delico.com>
Cc:	Lee Jones <lee.jones@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Marek Belisko <marek@...delico.com>, linux-omap@...r.kernel.org
Subject: Re: PROBLEM: bindings for drivers/mfd/twl4030-power.c

* Dr. H. Nikolaus Schaller <hns@...delico.com> [140817 08:46]:
> I am trying to make ti,use_poweroff work on 3.17-rc1 for the GTA04 board.
> Poweroff was broken for a while and I found that the driver isn't loaded at all.
> 
> It appears to me that commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
> did rename the compatible entry from "ti,twl4030-power" to "ti,twl4030-power-reset"
> but this was not documented in the bindings and of course our DT does not
> match.
> 
> Even your commit message talks about "ti,twl4030-power" although I can't find it
> in the code.

Hmm sorry did I accidentally remove ti,twl4030-power? If so, that should
be added back for sure. Do you have a patch for that already?
 
> Are "ti,twl4030-power" and "ti,twl4030-power-reset" doing the same?

No, they are separate where ti,twl4030-power does not configure the
twl4030 in any way where ti,twl4030-power-reset configures the warm
reset sequence.

For gta04, what you really want is to use ti,twl4030-power-idle or
even ti,twl4030-power-idle-osc-off if the board is wired to support
cutting off the oscillator.

And you probably also want to configure some wake-up interrupts at least
for the the UARTs in the board specific .dts file, see for example the
UART3 in the existing board files that have:

interrupts-extended = <&intc 74 &omap3_pmx_core OMAP3_UART3_RX>;

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/