linux-kernel - Re: [PATCH] arm64/crypto: remove redundant update of data

Open Source and information security mailing list archives

Message-ID: <CAKv+Gu8GjSi4r2hCbnhQ2rDFJaO_PH3=JmfKKTsELDqCuf_cLw@mail.gmail.com>
Date:	Mon, 25 Aug 2014 09:04:27 +0200
From:	Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:	Colin King <colin.king@...onical.com>
Cc:	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64/crypto: remove redundant update of data

On 24 August 2014 22:38, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> Originally found by cppcheck:
>
> [arch/arm64/crypto/sha2-ce-glue.c:153]: (warning) Assignment of
>   function parameter has no effect outside the function. Did you
>   forget dereferencing it?
>
> Updating data by blocks * SHA256_BLOCK_SIZE at the end of
> ha2_finup is redundant code and can be removed.
>

^^^ typo here

> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>


> ---
>  arch/arm64/crypto/sha2-ce-glue.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/crypto/sha2-ce-glue.c b/arch/arm64/crypto/sha2-ce-glue.c
> index c294e67..ae67e88 100644
> --- a/arch/arm64/crypto/sha2-ce-glue.c
> +++ b/arch/arm64/crypto/sha2-ce-glue.c
> @@ -150,7 +150,6 @@ static void sha2_finup(struct shash_desc *desc, const u8 *data,
>         kernel_neon_begin_partial(28);
>         sha2_ce_transform(blocks, data, sctx->state, NULL, len);
>         kernel_neon_end();
> -       data += blocks * SHA256_BLOCK_SIZE;
>  }
>
>  static int sha224_finup(struct shash_desc *desc, const u8 *data,
> --
> 2.1.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives