linux-kernel - Re: [PATCH] fs: btrfs: fix potential overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Aug 2014 23:45:22 -0700
From:	Brian Norris <computersforpeace@...il.com>
To:	Timofey Titovets <nefelim4ag@...il.com>
Cc:	Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>,
	linux-btrfs <linux-btrfs@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs: btrfs: fix potential overflow

On Sun, Aug 24, 2014 at 12:44:11PM +0300, Timofey Titovets wrote:
> 2014-08-24 8:41 GMT+03:00 Brian Norris <computeaboversforpeace@...il.com>:
> > --- a/fs/btrfs/scrub.c
> > +++ b/fs/btrfs/scrub.c
> > @@ -2320,26 +2320,26 @@ static noinline_for_stack int scrub_stripe(struct scrub_ctx *sctx,
> >         do_div(nstripes, map->stripe_len);
> >         if (map->type & BTRFS_BLOCK_GROUP_RAID0) {
> >                 offset = map->stripe_len * num;
> > -               increment = map->stripe_len * map->num_stripes;
> > +               increment *= map->num_stripes;
> >                 mirror_num = 1;
> >         } else if (map->type & BTRFS_BLOCK_GROUP_RAID10) {
> >                 int factor = map->num_stripes / map->sub_stripes;
> >                 offset = map->stripe_len * (num / map->sub_stripes);
> > -               increment = map->stripe_len * factor;
> > +               increment *= factor;
> >                 mirror_num = num % map->sub_stripes + 1;
> >         } else if (map->type & BTRFS_BLOCK_GROUP_RAID1) {
> > -               increment = map->stripe_len;
> > +               increment *= 1;
> Why? I think multiple by one is useless or i miss something?

A misguided attempt to keep the code structure intact. I'll drop these
for v2.

[snip]

Thanks,
Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/