linux-kernel - Re: [PATCH] Input: ALPS - suppress message about 'Unknown touchpad'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53FC4366.7050600@redhat.com>
Date:	Tue, 26 Aug 2014 10:20:54 +0200
From:	Hans de Goede <hdegoede@...hat.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org
CC:	Yunkang Tang <yunkang.tang@...alps.com>,
	Paul Menzel <paulepanter@...rs.sourceforge.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: ALPS - suppress message about 'Unknown touchpad'

Hi,

On 08/25/2014 08:30 PM, Dmitry Torokhov wrote:
> When we fail to match data returned by E7 and EC reports we state that we
> found "Unknown ALPS touchpad" whereas it is most likely it is not ALPS
> touchpad at all. Change wording a bit and reduce the message to debug so
> that it does not litter users logs and confuse them.
> 
> Reported-by: Paul Menzel <paulepanter@...rs.sourceforge.net>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

I noticed this too, and I agree that it is a confusing message:

Acked-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans

> ---
>  drivers/input/mouse/alps.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index a59a1a6..a956b98 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -2234,8 +2234,8 @@ static int alps_identify(struct psmouse *psmouse, struct alps_data *priv)
>  		return 0;
>  	}
>  
> -	psmouse_info(psmouse,
> -		     "Unknown ALPS touchpad: E7=%3ph, EC=%3ph\n", e7, ec);
> +	psmouse_dbg(psmouse,
> +		    "Likely not an ALPS touchpad: E7=%3ph, EC=%3ph\n", e7, ec);
>  
>  	return -EINVAL;
>  }
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/