lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Aug 2014 09:36:50 +0100 From: Lee Jones <lee.jones@...aro.org> To: Chris Zhong <zyw@...k-chips.com> Cc: Doug Anderson <dianders@...omium.org>, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Samuel Ortiz <sameo@...ux.intel.com>, Liam Girdwood <lgirdwood@...il.com>, "broonie@...nel.org" <broonie@...nel.org>, Alessandro Zummo <a.zummo@...ertech.it>, Mike Turquette <mturquette@...aro.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, rtc-linux@...glegroups.com, Grant Likely <grant.likely@...aro.org>, Lin Huang <hl@...k-chips.com>, Tao Huang <huangtao@...k-chips.com>, Eddie Cai <cf@...k-chips.com>, zhangqing <zhangqing@...k-chips.com>, xxx <xxx@...k-chips.com>, Heiko Stübner <heiko@...ech.de>, Olof Johansson <olof@...om.net>, Sonny Rao <sonnyrao@...omium.org>, Dmitry Torokhov <dtor@...omium.org>, Javier Martinez Canillas <javier.martinez@...labora.co.uk>, Kever Yang <kever.yang@...k-chips.com> Subject: Re: [PATCH v5 2/5] MFD: RK808: Add new mfd driver for RK808 On Tue, 26 Aug 2014, Chris Zhong wrote: > On 08/26/2014 04:44 AM, Doug Anderson wrote: > >On Mon, Aug 25, 2014 at 6:31 AM, Chris Zhong <zyw@...k-chips.com> wrote: [...] > >You need a Signed-off-by: Zhang Qing <zhangqing@...k-chips.com> > > Done [...] > >I think Lee's "Grim" comment here was that prefixing globals with "g_" > >is not consistent with the Linux coding style. Just remove the "g_". > > Done [...] > >{ RK808_BUCK3_CONFIG_REG, BUCK_ILMIN_MASK, BUCK_ILMIN_150MA }, > > > >instead of: > > > >{RK808_BUCK3_CONFIG_REG, BUCK_ILMIN_MASK, BUCK_ILMIN_150MA}, > > Done [...] > >nit: add spacing so that VB_LO_SEL_3500MV lines up under VB_LO_ACT > > Done [...] > >I think Lee wanted the above to be: > > > > { "rk808", }, > > Done [...] > >I think Lee wanted you to remove ".owner = THIS_MODULE" > > Done [...] You've just spammed 10(00)'s of people with an email that contains zero useful content. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists