linux-kernel - Re: [PATCH] drivers: scsi: #define missing include guards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 26 Aug 2014 11:26:55 +0200
From:	Hannes Reinecke <hare@...e.de>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>,
	"James E.J. Bottomley" <JBottomley@...allels.com>
CC:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: scsi: #define missing include guards

On 08/22/2014 02:37 PM, Rasmus Villemoes wrote:
> The four files aha1542.h, aha1740.h, gvp11.h and mvme147.h under
> drivers/scsi/ contain two-thirds of an include guard, but do not
> elsewhere.
>
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---
>   drivers/scsi/aha1542.h | 1 +
>   drivers/scsi/aha1740.h | 1 +
>   drivers/scsi/gvp11.h   | 1 +
>   drivers/scsi/mvme147.h | 1 +
>   4 files changed, 4 insertions(+)
>
> diff --git a/drivers/scsi/aha1542.h b/drivers/scsi/aha1542.h
> index b871d2b..8f4e07a 100644
> --- a/drivers/scsi/aha1542.h
> +++ b/drivers/scsi/aha1542.h
> @@ -1,4 +1,5 @@
>   #ifndef _AHA1542_H
> +#define _AHA1542_H
>
>   /* $Id: aha1542.h,v 1.1 1992/07/24 06:27:38 root Exp root $
>    *
> diff --git a/drivers/scsi/aha1740.h b/drivers/scsi/aha1740.h
> index af23fd6..7ea484f 100644
> --- a/drivers/scsi/aha1740.h
> +++ b/drivers/scsi/aha1740.h
> @@ -1,4 +1,5 @@
>   #ifndef _AHA1740_H
> +#define _AHA1740_H
>
>   /* $Id$
>    *
> diff --git a/drivers/scsi/gvp11.h b/drivers/scsi/gvp11.h
> index 852913c..5aabe90 100644
> --- a/drivers/scsi/gvp11.h
> +++ b/drivers/scsi/gvp11.h
> @@ -1,4 +1,5 @@
>   #ifndef GVP11_H
> +#define GVP11_H
>
>   /* $Id: gvp11.h,v 1.4 1997/01/19 23:07:12 davem Exp $
>    *
> diff --git a/drivers/scsi/mvme147.h b/drivers/scsi/mvme147.h
> index bfd4566..479e9b4 100644
> --- a/drivers/scsi/mvme147.h
> +++ b/drivers/scsi/mvme147.h
> @@ -1,4 +1,5 @@
>   #ifndef MVME147_H
> +#define MVME147_H
>
>   /* $Id: mvme147.h,v 1.4 1997/01/19 23:07:10 davem Exp $
>    *
>
Not that it matter much, but:

Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/