linux-kernel - Re: [PATCH] fbdev: Remove __init from chips_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 26 Aug 2014 12:50:03 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Pranith Kumar <bobby.prani@...il.com>
CC:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Rob Clark <robdclark@...il.com>,
	Jingoo Han <jg1.han@...sung.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>, open list:
	FRAMEBUFFER LAYER <linux-fbdev@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, ;
Subject: Re: [PATCH] fbdev: Remove __init from chips_hw_init() to fix build
 failure

On 21/08/14 15:23, Pranith Kumar wrote:
> Fix build failure caused as follows:
> 
> The function chipsfb_pci_init() references
> the function __init chips_hw_init().
> This is often because chipsfb_pci_init lacks a __init 
> annotation or the annotation of chips_hw_init is wrong.
> 
> make: *** [drivers] Error 2
> 
> by removing the __init annotation from chips_hw_init(). The other thing that
> could have been done was annotating chipsfb_pci_init(). But that cannot be done
> since chipsfb_pci_init() is called from non __init functions.
> 
> Signed-off-by: Pranith Kumar <bobby.prani@...il.com>
> ---
>  drivers/video/fbdev/chipsfb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c
> index 206a66b..59abdc6 100644
> --- a/drivers/video/fbdev/chipsfb.c
> +++ b/drivers/video/fbdev/chipsfb.c
> @@ -273,7 +273,7 @@ static struct chips_init_reg chips_init_xr[] = {
>  	{ 0xa8, 0x00 }
>  };
>  
> -static void __init chips_hw_init(void)
> +static void chips_hw_init(void)
>  {
>  	int i;
>  
> 

Thanks, queued for 3.17 fbdev fixes.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)