linux-kernel - Re: [Xen-devel] [PATCH 3/3] Support Xen pv-domains using PAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53FC83A1.5040000@suse.com>
Date:	Tue, 26 Aug 2014 14:54:57 +0200
From:	Juergen Gross <jgross@...e.com>
To:	David Vrabel <david.vrabel@...rix.com>, stefan.bader@...onical.com,
	toshi.kani@...com, linux-kernel@...r.kernel.org,
	xen-devel@...ts.xensource.com, konrad.wilk@...cle.com,
	ville.syrjala@...ux.intel.com, hpa@...or.com, x86@...nel.org
Subject: Re: [Xen-devel] [PATCH 3/3] Support Xen pv-domains using PAT

On 08/26/2014 12:59 PM, David Vrabel wrote:
> On 26/08/14 07:16, Juergen Gross wrote:
>> With the dynamical mapping between cache modes and pgprot values it is now
>> possible to use all cache modes via the Xen hypervisor PAT settings in a
>> pv domain.
>>
>> All to be done is to read the PAT configuration MSR and set up the translation
>> tables accordingly.
> [...]
>> +void xen_init_cache_types(void)
>> +{
>> +	pat_init_cache_modes();
>> +}
>
> No need to introduce xen_init_cache_types(), just call
> pat_init_cache_modes() directly.

Indeed. This was a leftover from a previous version.

>
>>   void xen_set_pat(u64 pat)
>>   {
>> -	/* We expect Linux to use a PAT setting of
>> -	 * UC UC- WC WB (ignoring the PAT flag) */
>> -	WARN_ON(pat != 0x0007010600070106ull);
>> +	xen_init_cache_types();
>>   }
>
> Remove xen_set_pat() and remove the special-cased handling of the PAT
> MSR from xen_write_msr_safe().

Hmm, why not. Reduces Xen specific handling even more.


Juergen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/