linux-kernel - Re: [PATCH] usb: gadget: net2280: Fix invalid handling of Reset irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140826155403.GE13949@saruman.home>
Date:	Tue, 26 Aug 2014 10:54:03 -0500
From:	Felipe Balbi <balbi@...com>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
CC:	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: net2280: Fix invalid handling of Reset irq

On Tue, Aug 26, 2014 at 05:50:12PM +0200, Ricardo Ribalda Delgado wrote:
> Without this patch, some hosts keeps restarting indefinitely the target.
> 
> Bug added on ae8e530a7e5d87592cb23996bee7fd6f1eb202ed usb: gadget:
> net2280: Code Cleanup

this should be just above you Signed-off-by on the form:

Fixes: ae8e530 (usb: gadget: net2280: Code Cleanup)

> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
> ---
>  drivers/usb/gadget/udc/net2280.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
> index f4eac11..2e95715 100644
> --- a/drivers/usb/gadget/udc/net2280.c
> +++ b/drivers/usb/gadget/udc/net2280.c
> @@ -3320,7 +3320,7 @@ static void handle_stat1_irqs(struct net2280 *dev, u32 stat)
>  	if (stat & tmp) {
>  		writel(tmp, &dev->regs->irqstat1);
>  		if ((((stat & BIT(ROOT_PORT_RESET_INTERRUPT)) &&
> -				(readl(&dev->usb->usbstat) & mask)) ||
> +				((readl(&dev->usb->usbstat) & mask) == 0)) ||
>  				((readl(&dev->usb->usbctl) &
>  					BIT(VBUS_PIN)) == 0)) &&
>  				(dev->gadget.speed != USB_SPEED_UNKNOWN)) {
> -- 
> 2.1.0
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)