linux-kernel - Re: [PATCH] regmap: Fix handling of volatile registers for format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53FCAE57.2050103@metafoo.de>
Date:	Tue, 26 Aug 2014 17:57:11 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Mark Brown <broonie@...nel.org>,
	Scott Jiang <scott.jiang.linux@...il.com>
CC:	linux-kernel@...r.kernel.org, Mark Brown <broonie@...aro.org>
Subject: Re: [PATCH] regmap: Fix handling of volatile registers for format_write()
 chips

On 08/26/2014 01:24 PM, Mark Brown wrote:
> From: Mark Brown <broonie@...aro.org>
>
> A previous over-zealous factorisation of code means that we only treat
> registers as volatile if they are readable. For most devices this is fine
> since normally most registers can be read and volatility implies
> readability but for format_write() devices where there is no readback from
> the hardware and we use volatility to mean simply uncacheability this means
> that we end up treating all registers as cacheble.
>
> A bigger refactoring of the code to clarify this is in order but as a fix
> make a minimal change and only check readability when checking volatility
> if there is no format_write() operation defined for the device.
>
> Signed-off-by: Mark Brown <broonie@...aro.org>

Tested-by: Lars-Peter Clausen <lars@...afoo.de>

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/