linux-kernel - Re: [PATCH 17/18] backlight: jornada720: remove 'else' after a return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140826162817.GD26707@lee--X1>
Date:	Tue, 26 Aug 2014 17:28:17 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	linux-kernel@...r.kernel.org, 'Bryan Wu' <cooloney@...il.com>
Subject: Re: [PATCH 17/18] backlight: jornada720: remove 'else' after a return

On Tue, 26 Aug 2014, Jingoo Han wrote:

> Fixed the following checkpatch warning.
> 
>   WARNING: else is not generally useful after a break or return
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>  drivers/video/backlight/jornada720_lcd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/backlight/jornada720_lcd.c
> index 228bc319de19..1cf3d59f1e7f 100644
> --- a/drivers/video/backlight/jornada720_lcd.c
> +++ b/drivers/video/backlight/jornada720_lcd.c
> @@ -30,8 +30,8 @@ static int jornada_lcd_get_power(struct lcd_device *ld)
>  	/* LDD2 in PPC = LCD POWER */
>  	if (PPSR & PPC_LDD2)
>  		return FB_BLANK_UNBLANK;	/* PW ON */
> -	else
> -		return FB_BLANK_POWERDOWN;	/* PW OFF */
> +
> +	return FB_BLANK_POWERDOWN;	/* PW OFF */

How about:

  return PPSR & PPC_LDD2 ? FB_BLANK_UNBLANK : FB_BLANK_POWERDOWN;

>  }
>  
>  static int jornada_lcd_get_contrast(struct lcd_device *ld)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/