linux-kernel - Re: [PATCH 16/18] backlight: jornada720: remove 'else' after a return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140826162951.GF26707@lee--X1>
Date:	Tue, 26 Aug 2014 17:29:51 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	linux-kernel@...r.kernel.org, 'Bryan Wu' <cooloney@...il.com>
Subject: Re: [PATCH 16/18] backlight: jornada720: remove 'else' after a return

On Tue, 26 Aug 2014, Jingoo Han wrote:

> Fixed the following checkpatch warning.
> 
>   WARNING: else is not generally useful after a break or return
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>  drivers/video/backlight/jornada720_bl.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Acked-by: Lee Jones <lee.jones@...aro.org>

> diff --git a/drivers/video/backlight/jornada720_bl.c b/drivers/video/backlight/jornada720_bl.c
> index 6ce96b4a8796..7e6ff5346892 100644
> --- a/drivers/video/backlight/jornada720_bl.c
> +++ b/drivers/video/backlight/jornada720_bl.c
> @@ -41,11 +41,11 @@ static int jornada_bl_get_brightness(struct backlight_device *bd)
>  		dev_err(&bd->dev, "get brightness timeout\n");
>  		jornada_ssp_end();
>  		return -ETIMEDOUT;
> -	} else {
> -		/* exchange txdummy for value */
> -		ret = jornada_ssp_byte(TXDUMMY);
>  	}
>  
> +	/* exchange txdummy for value */
> +	ret = jornada_ssp_byte(TXDUMMY);
> +
>  	jornada_ssp_end();
>  
>  	return BL_MAX_BRIGHT - ret;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/