linux-kernel - Re: [PATCH 09/18] backlight: lm3639: remove unnecessary return statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140826163407.GO26707@lee--X1>
Date:	Tue, 26 Aug 2014 17:34:07 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	linux-kernel@...r.kernel.org, 'Bryan Wu' <cooloney@...il.com>
Subject: Re: [PATCH 09/18] backlight: lm3639: remove unnecessary return
 statements

On Tue, 26 Aug 2014, Jingoo Han wrote:

> Fixed the following checkpatch warning.
> 
>   WARNING: void function return statements are not generally useful
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>  drivers/video/backlight/lm3639_bl.c | 2 --
>  1 file changed, 2 deletions(-)

Acked-by: Lee Jones <lee.jones@...aro.org>

> diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c
> index 5f36808d214f..cd50df5807ea 100644
> --- a/drivers/video/backlight/lm3639_bl.c
> +++ b/drivers/video/backlight/lm3639_bl.c
> @@ -254,7 +254,6 @@ static void lm3639_torch_brightness_set(struct led_classdev *cdev,
>  	return;
>  out:
>  	dev_err(pchip->dev, "i2c failed to access register\n");
> -	return;
>  }
>  
>  /* flash */
> @@ -293,7 +292,6 @@ static void lm3639_flash_brightness_set(struct led_classdev *cdev,
>  	return;
>  out:
>  	dev_err(pchip->dev, "i2c failed to access register\n");
> -	return;
>  }
>  
>  static const struct regmap_config lm3639_regmap = {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/