linux-kernel - Re: [PATCH 07/18] backlight: ili922x: remove 'else' after a return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140826163515.GQ26707@lee--X1>
Date:	Tue, 26 Aug 2014 17:35:15 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	linux-kernel@...r.kernel.org, 'Bryan Wu' <cooloney@...il.com>
Subject: Re: [PATCH 07/18] backlight: ili922x: remove 'else' after a return

On Tue, 26 Aug 2014, Jingoo Han wrote:

> Fixed the following checkpatch warning.
> 
>   WARNING: else is not generally useful after a break or return
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>  drivers/video/backlight/ili922x.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)

Acked-by: Lee Jones <lee.jones@...aro.org>

> diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c
> index ea67fe199e34..e7f0890cc211 100644
> --- a/drivers/video/backlight/ili922x.c
> +++ b/drivers/video/backlight/ili922x.c
> @@ -495,17 +495,18 @@ static int ili922x_probe(struct spi_device *spi)
>  			"no LCD found: Chip ID 0x%x, ret %d\n",
>  			reg, ret);
>  		return -ENODEV;
> -	} else {
> -		dev_info(&spi->dev, "ILI%x found, SPI freq %d, mode %d\n",
> -			 reg, spi->max_speed_hz, spi->mode);
>  	}
>  
> +	dev_info(&spi->dev, "ILI%x found, SPI freq %d, mode %d\n",
> +		 reg, spi->max_speed_hz, spi->mode);
> +
>  	ret = ili922x_read_status(spi, &reg);
>  	if (ret) {
>  		dev_err(&spi->dev, "reading RS failed...\n");
>  		return ret;
> -	} else
> -		dev_dbg(&spi->dev, "status: 0x%x\n", reg);
> +	}
> +
> +	dev_dbg(&spi->dev, "status: 0x%x\n", reg);
>  
>  	ili922x_display_init(spi);
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/