| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Aug 2014 23:27:37 +0200 (CEST) From: Thomas Gleixner <tglx@...utronix.de> To: Andi Kleen <andi@...stfloor.org> cc: peterz@...radead.org, linux-kernel@...r.kernel.org, mingo@...nel.org, eranian@...gle.com, Andi Kleen <ak@...ux.intel.com> Subject: Re: [PATCH 1/5] perf, x86: Remove incorrect model number from Haswell perf On Mon, 25 Aug 2014, Andi Kleen wrote: > From: Andi Kleen <ak@...ux.intel.com> > > Signed-off-by: Andi Kleen <ak@...ux.intel.com> > --- > arch/x86/kernel/cpu/perf_event_intel.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c > index 89bc750..e280a86 100644 > --- a/arch/x86/kernel/cpu/perf_event_intel.c > +++ b/arch/x86/kernel/cpu/perf_event_intel.c > @@ -2541,10 +2541,9 @@ __init int intel_pmu_init(void) > > > case 60: /* 22nm Haswell */ > + case 70: > case 63: > case 69: > - case 70: > - case 71: So what's the point of making the obvious onliner patch - case 71: into something which reorders the sorted case numbers? And of course, this patch is missing any explanation WHY 71 is incorrect and how it got there in the first place. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists