linux-kernel - Re: [PATCH 1/2] regmap: cache: Fix regcache_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140827115819.GB17528@sirena.org.uk>
Date:	Wed, 27 Aug 2014 12:58:19 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH 1/2] regmap: cache: Fix regcache_sync_block for
 non-autoincrementing devices

On Tue, Aug 26, 2014 at 05:03:12PM +0300, Jarkko Nikula wrote:
> Commit 75a5f89f635c ("regmap: cache: Write consecutive registers in a single
> block write") expected that autoincrementing writes are supported if
> hardware has a register format which can support raw writes.
> 
> This is not necessarily true and thus for instance rbtree sync can fail when
> there is need to sync multiple consecutive registers but block write to
> device fails due not supported autoincrementing writes.
> 
> Fix this by spliting raw block sync to series of single register writes for
> devices that don't support autoincrementing writes.

This seems like the wrong place for this - we already have a one
register at a time mechanism for syncing the registers, making the block
write scheme able to do it as well is rather missing the point.  Better
to move the check into sync_block() instead.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)