linux-kernel - Re: [PATCH (net-next) v2] net: stmmac: fix warning from Sparse for socfpga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFiDJ5-S40ve--sg_2sskx2BBm7zmZdmDmNpyMeXnHcVdrx8ag@mail.gmail.com>
Date:	Wed, 27 Aug 2014 09:24:22 +0800
From:	Ley Foon Tan <lftan@...era.com>
To:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
Cc:	netdev@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Vince Bridgers <vbridger@...era.com>
Subject: Re: [PATCH (net-next) v2] net: stmmac: fix warning from Sparse for socfpga

On Tue, Aug 26, 2014 at 6:13 PM, Giuseppe CAVALLARO
<peppe.cavallaro@...com> wrote:
> On 8/26/2014 11:47 AM, Ley Foon Tan wrote:
>>
>> Warning:
>> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:41:
>> sparse: cast removes address space of expression
>> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:38:
>> sparse: incorrect type in assignment (different address spaces)
>>
>> Signed-off-by: Ley Foon Tan <lftan@...era.com>
>> ---
>>   drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
>> b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
>> index cd613d7..ff54a1f 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
>> @@ -119,7 +119,7 @@ static int socfpga_dwmac_parse_data(struct
>> socfpga_dwmac *dwmac, struct device *
>>                         return -EINVAL;
>>                 }
>>
>> -               dwmac->splitter_base = (void *)devm_ioremap_resource(dev,
>> +               dwmac->splitter_base = devm_ioremap_resource(dev,
>>                         &res_splitter);
>
>
> can the ioremap call stay in a single line ? or pls review indent looks
> NOK

It will has "line over 80 characters" if it is one line code.
BTW, this patch passed "checkpatch.pl" script.
Let me know if think indent is not okay.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/