linux-kernel - Re: [PATCH] regmap: Don't attempt block writes when syncing cache on single

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53FDDD87.4030904@linux.intel.com>
Date:	Wed, 27 Aug 2014 16:30:47 +0300
From:	Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To:	Mark Brown <broonie@...nel.org>
CC:	linux-kernel@...r.kernel.org, linaro-kernel@...ts.linaro.org,
	Mark Brown <broonie@...aro.org>
Subject: Re: [PATCH] regmap: Don't attempt block writes when syncing cache
 on single_rw devices

On 08/27/2014 03:09 PM, Mark Brown wrote:
> From: Mark Brown <broonie@...aro.org>
>
> If the device can't support block writes then don't attempt to use raw
> syncing which will automatically generate block writes for adjacent
> registers, use the existing _single() block syncing implementation.
>
> Reported-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
> Signed-off-by: Mark Brown <broonie@...aro.org>
> ---
>   drivers/base/regmap/regcache.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
This works too with RT5642. It appeared page select for _regmap_write() 
is actually handled implicitly for certain cases. regmap_init() sets 
"map->reg_write = _regmap_bus_raw_write" in this case and 
_regmap_bus_raw_write() then calls _regmap_raw_write(). I guess that can 
be fixed when doing other cleanups or if some setup hits it.

Tested-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/