lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Aug 2014 16:07:12 +0200 From: Hannes Reinecke <hare@...e.de> To: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@...achi.com> CC: linux-scsi@...r.kernel.org, "Martin K. Petersen" <martin.petersen@...cle.com>, yrl.pp-manager.tt@...achi.com, linux-kernel@...r.kernel.org, "James E.J. Bottomley" <JBottomley@...allels.com>, Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>, Doug Gilbert <dgilbert@...erlog.com>, Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>, Christoph Hellwig <hch@....de> Subject: Re: [RFC PATCH 06/10] scsi/sd: Delete extra scsi_show_extd_sense() in sd_print_sense_hdr() On 08/08/2014 01:50 PM, Yoshihiro YUNOMAE wrote: > sd_print_sense_hdr() calls scsi_show_extd_sense(), > but scsi_print_sense_hdr() also calls scsi_show_extd_sense(). > We can get same result, so we delete it. > > Note: > Calling scsi_show_extd_sense() is introduced in fdd8b297. > > Signed-off-by: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@...achi.com> > Cc: Hannes Reinecke <hare@...e.de> > Cc: Doug Gilbert <dgilbert@...erlog.com> > Cc: Martin K. Petersen <martin.petersen@...cle.com> > Cc: Christoph Hellwig <hch@....de> > Cc: "James E.J. Bottomley" <JBottomley@...allels.com> > Cc: Hidehiro Kawai <hidehiro.kawai.ez@...achi.com> > Cc: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> > --- > drivers/scsi/sd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index 8d7204a..22dd214 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -3286,8 +3286,6 @@ static void sd_print_sense_hdr(struct scsi_disk *sdkp, > struct scsi_sense_hdr *sshdr) > { > scsi_print_sense_hdr(sdkp->device, sdkp->disk->disk_name, sshdr); > - scsi_show_extd_sense(sdkp->device, sdkp->disk->disk_name, > - sshdr->asc, sshdr->ascq); > } > > static void sd_print_result(struct scsi_disk *sdkp, int result) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > A similar patch has been applied to my scsi-logging tree. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@...e.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists