linux-kernel - Re: [PATCH resend] checkpatch: Enable whitespace checks for DTS files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 27 Aug 2014 09:37:13 -0700
From:	Joe Perches <joe@...ches.com>
To:	Geert Uytterhoeven <geert+renesas@...der.be>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Andy Whitcroft <apw@...onical.com>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH resend] checkpatch: Enable whitespace checks for DTS
 files

(adding Andrew Morton)

On Wed, 2014-08-27 at 17:08 +0200, Geert Uytterhoeven wrote:
> When run on *.dtsi or *.dts files, the whitespace checks were skipped,
> while they are valid for DTS files.  Hence stop skipping them.
> 
> I ran checkpatch on all in-tree DTS files, and didn't notice any error or
> warning messages that are inappropriate for DTS files.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Acked-by: Joe Perches <joe@...ches.com>

> ---
>  scripts/checkpatch.pl | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 31a731e06f50..ded90b6d7e17 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2338,7 +2338,7 @@ sub process {
>  		}
>  
>  # check we are in a valid source file if not then ignore this hunk
> -		next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
> +		next if ($realfile !~ /\.(h|c|s|S|pl|sh|dtsi|dts)$/);
>  
>  #line length limit
>  		if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
> @@ -2399,7 +2399,7 @@ sub process {
>  		}
>  
>  # check we are in a valid source file C or perl if not then ignore this hunk
> -		next if ($realfile !~ /\.(h|c|pl)$/);
> +		next if ($realfile !~ /\.(h|c|pl|dtsi|dts)$/);
>  
>  # at the beginning of a line any tabs must come first and anything
>  # more than 8 must use tabs.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/