linux-kernel - Re: [PATCH 1/1] regulator: max77802: set opmode to normal if off is read from hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Aug 2014 20:32:38 +0200
From:	Tomasz Figa <tomasz.figa@...il.com>
To:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>,
	Mark Brown <broonie@...nel.org>
CC:	Doug Anderson <dianders@...omium.org>,
	Olof Johansson <olof@...om.net>,
	Yuvaraj Kumar C D <yuvaraj.cd@...il.com>,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] regulator: max77802: set opmode to normal if off
 is read from hw

On 26.08.2014 13:37, Javier Martinez Canillas wrote:
> +		/*
> +		 * If the regulator is disabled and the system warm rebooted,
> +		 * the hardware reports OFF as the regulator operating mode.
> +		 * Default to operating mode NORMAL in that case.
> +		 */
> +		if (val == MAX77802_OPMODE_OFF)
> +			max77802->opmode[id] = MAX77802_OPMODE_NORMAL;
> +		else
> +			max77802->opmode[id] = val;

I might be missing something, but I believe I see a flaw here. If after
a cold boot opmode is something else than OFF or NORMAL, the kernel
starts, turns the regulator off and does warm reboot, the setting is
lost and the regulator is switched to NORMAL mode.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/