linux-kernel - Re: [PATCH v6 4/4] drivers/hwmon/menf21bmc_hwmon: introduce MEN14F021P00 BMC HWMON driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140827183843.GC2198@roeck-us.net>
Date:	Wed, 27 Aug 2014 11:38:43 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Andreas Werner <andreas.werner@....de>
Cc:	linux-kernel@...r.kernel.org, sameo@...ux.intel.com,
	lee.jones@...aro.org, lm-sensors@...sensors.org, wim@...ana.be,
	linux-watchdog@...r.kernel.org, cooloney@...il.com,
	rpurdie@...ys.net, linux-leds@...r.kernel.org
Subject: Re: [PATCH v6 4/4] drivers/hwmon/menf21bmc_hwmon: introduce
 MEN14F021P00 BMC HWMON driver

On Wed, Aug 27, 2014 at 07:53:06PM +0200, Andreas Werner wrote:
> Added driver to support the 14F021P00 BMC Hardware Monitoring.
> The BMC is a Board Management Controller including monitoring of the
> board voltages.
> 
> Signed-off-by: Andreas Werner <andreas.werner@....de>

Looks good, though I do have one comment ...

> +
> +	hwmon_dev = devm_hwmon_device_register_with_groups(&pdev->dev,
> +						   "menf21bmc", drv_data,
> +						   menf21bmc_hwmon_groups);
> +	if (IS_ERR(hwmon_dev))
> +		return PTR_ERR(hwmon_dev);
> +
> +	dev_info(&pdev->dev, "MEN 14F021P00 BMC hwmon device enabled");
> +
You removed the dev_info from the mfd driver but left it in the client
drivers.  If you'd drop it here as well, you could use
'return PTR_ERR_OR_ZERO(hwmon_dev);'.  Just a suggestion, not mandatory.

Either case,

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

I assume this will go in through the mfd tree.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/