linux-kernel - Re: [PATCH v3 2/2] usb: Add LED triggers for USB activity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140827193028.GK6347@saruman.home>
Date:	Wed, 27 Aug 2014 14:30:28 -0500
From:	Felipe Balbi <balbi@...com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	Michal Sojka <sojka@...ica.cz>, <linux-usb@...r.kernel.org>,
	Bryan Wu <cooloney@...il.com>, Felipe Balbi <balbi@...com>,
	Linux LED Subsystem <linux-leds@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <michal.vokac@...ap.cz>
Subject: Re: [PATCH v3 2/2] usb: Add LED triggers for USB activity

On Wed, Aug 27, 2014 at 12:27:51PM -0700, Greg Kroah-Hartman wrote:
> On Wed, Aug 27, 2014 at 03:03:45PM +0200, Michal Sojka wrote:
> > With this patch, USB activity can be signaled by blinking a LED. There
> > are two triggers, one for activity on USB host and one for USB gadget.
> > 
> > Both trigger should work with all host/device controllers. Tested only
> > with musb.
> > 
> > Signed-off-by: Michal Sojka <sojka@...ica.cz>
> > ---
> >  drivers/usb/Kconfig                           | 11 ++++++
> >  drivers/usb/common/Makefile                   |  5 ++-
> >  drivers/usb/common/{usb-common.c => common.c} |  0
> 
> I don't mind renaming files, but don't "hide" it in this patch, do it in
> a separate patch please, and then base your next patch on this one.

+1

yeah, this prevents us from reviewing the actual changes

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)