linux-kernel - Re: [PATCH] pci/pci-sysfs: Set pci interface in uppercase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPybu_2p6+VXj0s+yWGRvTO-1W-=rkhCBVKFHqa25joEO+Q3zA@mail.gmail.com>
Date:	Wed, 27 Aug 2014 23:10:42 +0200
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pci/pci-sysfs: Set pci interface in uppercase

Hello Greg

On Wed, Aug 27, 2014 at 11:04 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Wed, Aug 27, 2014 at 10:56:57PM +0200, Ricardo Ribalda Delgado wrote:
>> No worries,
>>
>> I have to mark for stable it or Bjorn? It it is me, how :) ?
>
> Bjorn can when he applies it, for details on the process, see the kernel
> file Documentation/stable_kernel_rules.txt
>
>> ps: For other people reading this thread, the kmod/modprobe is in
>> http://anonscm.debian.org/cgit/users/md/kmod.git/tree/libkmod/libkmod-index.c
>> and handles all the modalias as strings without differing the type.
>
> That sounds wrong, and odds are, will cause more problems over time.
> These are hex values, not strings :(

I totally see your point, but I disagree on the method.

I think is our resposibility (modalias/file2alias) to provide a
matcheable string, otherwise modprobe should be aware of all the types
(pci, usb, spi, vmbus.....)

As we keep adding types, and they don't follow any standard, we would
be adding a dependecy between kmod and the kernel, and duplicating
code.  That is bad systemwise

Maybe the code on kmod should not be case sensitive, that is all :)

>
> thanks,
>
> greg k-h

Thanks



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/