linux-kernel - Re: [PATCH 1/4] mfd: Add Ricoh RN5T618 PMIC core driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140827211237.GA24921@gmail.com>
Date:	Wed, 27 Aug 2014 23:12:37 +0200
From:	Beniamino Galvani <b.galvani@...il.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-kernel@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>,
	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Wim Van Sebroeck <wim@...ana.be>,
	linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Grant Likely <grant.likely@...aro.org>,
	Carlo Caione <carlo@...one.org>
Subject: Re: [PATCH 1/4] mfd: Add Ricoh RN5T618 PMIC core driver

On Wed, Aug 27, 2014 at 08:56:14AM +0100, Lee Jones wrote:
[...]
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 8d5fad2..fae8c5b 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -582,6 +582,17 @@ config MFD_RC5T583
> >  	  Additional drivers must be enabled in order to use the
> >  	  different functionality of the device.
> >  
> > +config MFD_RN5T618
> > +	bool "Ricoh RN5T5618 PMIC"
> 
> Shouldn't this be tristate?

Yes, I suppose the driver would work also as a module, I only have to
uninstall the pm_power_off hook on module removal.

> > +++ b/drivers/mfd/rn5t618.c
> > @@ -0,0 +1,129 @@
> 
> [...]
> 
> > +static int rn5t618_i2c_probe(struct i2c_client *i2c,
> > +			     const struct i2c_device_id *id)
> > +{
> 
> [...]
> 
> > +	dev_info(&i2c->dev, "RN5T618 MFD driver loaded");
> 
> Can you remove this line?  We normally only print things when
> information is gathered from a chip i.e. version information and the
> like.

I will remove it, thanks.

Beniamino
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/