linux-kernel - Re: [PATCH 2/2] x86: iosf: Add debugfs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53FE59B8.5080401@zytor.com>
Date:	Wed, 27 Aug 2014 15:20:40 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	"David E. Box" <david.e.box@...ux.intel.com>, tglx@...utronix.de,
	mingo@...hat.com
CC:	x86@...nel.org, linux-kernel@...r.kernel.org, alan@...ux.intel.com
Subject: Re: [PATCH 2/2] x86: iosf: Add debugfs support

On 08/27/2014 02:40 PM, David E. Box wrote:
> Allows access to the iosf sideband through debugfs.

This would break if compiled without CONFIG_DEBUGFS support, which is
often a requirement for security reasons.

Please conditionalize this code, and if practical move it to a separate
.c file.

Most drivers also have separate config options to enable their specific
debugfs options.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/