linux-kernel - Re: [PATCH 1/1] regulator: max77802: set opmode to normal if off is read from hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140828100155.GK17528@sirena.org.uk>
Date:	Thu, 28 Aug 2014 11:01:55 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
Cc:	Javier Martinez Canillas <javier@...hile0.org>,
	Tomasz Figa <tomasz.figa@...il.com>,
	Doug Anderson <dianders@...omium.org>,
	Olof Johansson <olof@...om.net>,
	Yuvaraj Kumar C D <yuvaraj.cd@...il.com>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] regulator: max77802: set opmode to normal if off is
 read from hw

On Thu, Aug 28, 2014 at 11:59:16AM +0200, Javier Martinez Canillas wrote:
> > On 28/08/2014, at 10:28, Mark Brown <broonie@...nel.org> wrote:

> >> Yes, AFAIK the bootloader (none of them because Chromebooks use two
> >> chained U-boots) change the regulators default opmode so once is set
> >> to OFF on .disable, that value is preserved on warm reboot. This made
> >> sense with the Chrome OS kernel since the kernel always set the opmode
> >> defined in the "regulator-op-mode" DT property and did not relied on
> >> the bootloader to set the most efficient default opmode.

> > I'm sorry but this is just really unclear.  Does the bootloader change
> > the mode or does it not change the mode?

> I meant that the boot loader *does not* change the mode and is Linux
> who change it, sorry for the confusion.

Ah, OK.  Like I say that's a separate concern to the one Tomasz was
raising - he is worried about the case where we change the mode in the
bootloader but only on cold boot.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)