linux-kernel - Re: [PATCH] drivers/xen/evtchn.c: Check failure for evtchn_make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53FF4FA5.4050105@citrix.com>
Date:	Thu, 28 Aug 2014 16:49:57 +0100
From:	David Vrabel <david.vrabel@...rix.com>
To:	Chen Gang <gang.chen.5i5j@...il.com>, <konrad.wilk@...cle.com>,
	<boris.ostrovsky@...cle.com>
CC:	<xen-devel@...ts.xenproject.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/xen/evtchn.c: Check failure for evtchn_make_refcounted()

On 28/08/14 16:13, Chen Gang wrote:
> evtchn_make_refcounted() may return failure, so need process the failure
> case. In failure case, it need call unbind_from_irqhandler() just like
> evtchn_unbind_from_user() has done.
> 
> irq_from_evtchn() must be OK when bind_evtchn_to_irqhandler() succeed,
> so need not check it again.
> 
> Also still need remain the closing port code, because when the failure
> occurs, unbind_from_irqhandler() will not close port internally.

None of the evtchn_make_refcounted() failures can occur since we know we
have a valid irq and info at the single call site.

I would like to see this fixed by refactoring the code to remove
evtchn_make_refcounted() by making all irqs for event channels reference
counted.  These no need for this refcounting to be optional.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/