linux-kernel - Re: [PATCH v3 1/4] thermal: rockchip: add driver for thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4488604.oBeB6it8Vr@wuerfel>
Date:	Thu, 28 Aug 2014 18:16:27 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Heiko Stübner <heiko@...ech.de>
Cc:	Eduardo Valentin <edubezval@...il.com>,
	Caesar Wang <caesar.wang@...k-chips.com>, rui.zhang@...el.com,
	grant.likely@...aro.org, robh+dt@...nel.org,
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org, huangtao@...k-chips.com,
	cf@...k-chips.com, dianders@...omium.org, dtor@...omium.org,
	zyw@...k-chips.com, addy.ke@...k-chips.com,
	dmitry.torokhov@...il.com, zhaoyifeng <zyf@...k-chips.com>,
	linux-iio@...r.kernel.org, Jonathan Cameron <jic23@...nel.org>
Subject: Re: [PATCH v3 1/4] thermal: rockchip: add driver for thermal

On Thursday 28 August 2014 18:11:43 Heiko Stübner wrote:
> Am Donnerstag, 28. August 2014, 10:37:35 schrieb Eduardo Valentin:
> > > On the driver side, I believe the correct way to deal with this setup
> > > is to split your driver into a generic drivers/iio/adc/rockchips-tsadc.c
> > > file, and a smaller thermal driver that uses the iio in-kernel interfaces,
> > > ideally one that is independent of the underlying hardware and can
> > > work on any ADC implementation.
> > 
> > Agreed. If you can write such interface and make your driver to work in
> > such way, that would be great.
> 
> But I currently don't see how you would model the temperature handling parts 
> from a generic thermal driver to a generic adc driver for the rk3288-tsadc.
> 
> I guess the general temperature irq handling would use iio-triggers? But how 
> does the target temperature get into the TSADC_COMP1_INT register.
> 
> Also when getting the temperature, Caesar's driver compares it to its trip 
> points and sets the next trip point depending on the current temperature 
> (passive <-> critical) in rockchip_get_temp.
> 
> Maybe there is some completely easy way for this, but currently I don't see 
> it.

Eduardo earlier today replied to an email about a generic driver for
thermal, which was posted in February but hasn't been merged.
See https://lkml.org/lkml/2014/2/5/810

There may be a newer version of this patch, which I haven't found.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/