linux-kernel - Re: [PATCH] irqchip: keystone: remove warning unsigned 'kirq->irq' is never less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 Aug 2014 20:26:43 +0300
From:	Grygorii Strashko <grygorii.strashko@...com>
To:	Thomas Gleixner <tglx@...utronix.de>, <santosh.shilimkar@...com>,
	Jason Cooper <jason@...edaemon.net>
CC:	Dan Carpenter <dan.carpenter@...cle.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] irqchip: keystone: remove warning unsigned 'kirq->irq'
 is never less than zero

Hi Jason,

On 08/28/2014 08:16 PM, Grygorii Strashko wrote:
> Remove static checker warning:
>
> 	drivers/irqchip/irq-keystone.c:166 keystone_irq_probe()
> 	warn: unsigned 'kirq->irq' is never less than zero.
>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
> ---

Sorry, forgot to mention that this is incremental fix for the patch
https://lkml.org/lkml/2014/7/23/891
"[PATCH v2] irqchip: add keystone irq controller ip driver" which is
in linux-next already.

>   drivers/irqchip/irq-keystone.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-keystone.c b/drivers/irqchip/irq-keystone.c
> index fea26bc..608abf9 100644
> --- a/drivers/irqchip/irq-keystone.c
> +++ b/drivers/irqchip/irq-keystone.c
> @@ -36,7 +36,7 @@ struct keystone_irq_device {
>   	struct device		*dev;
>   	struct irq_chip		 chip;
>   	u32			 mask;
> -	u32			 irq;
> +	int			 irq;
>   	struct irq_domain	*irqd;
>   	struct regmap		*devctrl_regs;
>   	u32			devctrl_offset;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/