linux-kernel - Re: [PATCH 1/5] usb: phy: twl4030-usb: Remove unused irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140828022051.GB5273@saruman.home>
Date:	Wed, 27 Aug 2014 21:20:53 -0500
From:	Felipe Balbi <balbi@...com>
To:	Tony Lindgren <tony@...mide.com>
CC:	<kishon@...com>, <balbi@...com>, <linux-kernel@...r.kernel.org>,
	<linux-usb@...r.kernel.org>, <linux-omap@...r.kernel.org>
Subject: Re: [PATCH 1/5] usb: phy: twl4030-usb: Remove unused irq_enabled

Hi,

On Wed, Aug 27, 2014 at 04:28:07PM -0700, Tony Lindgren wrote:
> It's not being used any longer.
> 
> Signed-off-by: Tony Lindgren <tony@...mide.com>
> ---
>  drivers/phy/phy-twl4030-usb.c     | 2 --
>  drivers/usb/phy/phy-twl6030-usb.c | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/drivers/phy/phy-twl4030-usb.c b/drivers/phy/phy-twl4030-usb.c
> index 9cd33a4..bc28ecc 100644
> --- a/drivers/phy/phy-twl4030-usb.c
> +++ b/drivers/phy/phy-twl4030-usb.c
> @@ -164,7 +164,6 @@ struct twl4030_usb {
>  	enum omap_musb_vbus_id_status linkstat;
>  	bool			vbus_supplied;
>  	u8			asleep;
> -	bool			irq_enabled;
>  
>  	struct delayed_work	id_workaround_work;
>  };
> @@ -755,7 +754,6 @@ static int twl4030_usb_probe(struct platform_device *pdev)
>  	 * set_host() and/or set_peripheral() ... OTG_capable boards
>  	 * need both handles, otherwise just one suffices.
>  	 */
> -	twl->irq_enabled = true;
>  	status = devm_request_threaded_irq(twl->dev, twl->irq, NULL,
>  			twl4030_usb_irq, IRQF_TRIGGER_FALLING |
>  			IRQF_TRIGGER_RISING | IRQF_ONESHOT, "twl4030_usb", twl);

can you split this into two patches ? drivers/phy will be taken by
Kishon and drivers/usb/phy by me. another possibility is that I get an
Acked-by from Kishon and I can take $subject as is.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)