linux-kernel - Re: [PATCH] Documentation/video4linux: don't build without CONFIG_VIDEO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53FF9425.6010302@infradead.org>
Date:	Thu, 28 Aug 2014 13:42:13 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Andrey Vagin <avagin@...nvz.org>, linux-doc@...r.kernel.org
CC:	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
	Peter Foley <pefoley2@...oley.com>,
	Mauro Carvalho Chehab <m.chehab@...sung.com>
Subject: Re: [PATCH] Documentation/video4linux: don't build without CONFIG_VIDEO_V4L2

On 08/28/14 13:34, Andrey Vagin wrote:
> Otherwise we get warnings:
> WARNING: "vb2_ops_wait_finish" [Documentation//video4linux/v4l2-pci-skeleton.ko] undefined!
> WARNING: "vb2_ops_wait_prepare" [Documentation//video4linux/v4l2-pci-skeleton.ko] undefined!
> ...
> WARNING: "video_unregister_device" [Documentation//video4linux/v4l2-pci-skeleton.ko] undefined!
> 
> Fixes: 8db5ab4b50fb ("Documentation: add makefiles for more targets")
> 
> Cc: Peter Foley <pefoley2@...oley.com>
> Cc: Mauro Carvalho Chehab <m.chehab@...sung.com>
> Cc: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Andrey Vagin <avagin@...nvz.org>
> ---
>  Documentation/video4linux/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/video4linux/Makefile b/Documentation/video4linux/Makefile
> index d58101e..f19f38e 100644
> --- a/Documentation/video4linux/Makefile
> +++ b/Documentation/video4linux/Makefile
> @@ -1 +1,3 @@
> +ifneq ($(CONFIG_VIDEO_V4L2),)
>  obj-m := v4l2-pci-skeleton.o
> +endif
> 

The Kconfig file for this module says:

config VIDEO_PCI_SKELETON
	tristate "Skeleton PCI V4L2 driver"
	depends on PCI && BUILD_DOCSRC
	depends on VIDEO_V4L2 && VIDEOBUF2_CORE && VIDEOBUF2_MEMOPS

so it should already be limited to VIDEO_V4L2 being enabled.

What kernel or linux-next version did you see a problem with?

Please send the failing .config file so that I can check it.

Thanks.

-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/