linux-kernel - Re: [PATCH] crypto: qat - Use pci_enable_msix_exact() instead of pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Aug 2014 10:10:55 +0100
From:	Alexander Gordeev <agordeev@...hat.com>
To:	linux-kernel@...r.kernel.org
Cc:	Tadeusz Struk <tadeusz.struk@...el.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>, qat-linux@...el.com,
	linux-crypto@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH] crypto: qat - Use pci_enable_msix_exact() instead of
 pci_enable_msix()

On Tue, Aug 19, 2014 at 09:32:04AM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range()  or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.

Hello Gentleman,

This trivial patch blocks phasing out of deprecated
pci_enable_msix() function. Could someone review and
accept it, please?

Thanks!

> Cc: Tadeusz Struk <tadeusz.struk@...el.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: qat-linux@...el.com
> Cc: linux-crypto@...r.kernel.org
> Cc: linux-pci@...r.kernel.org
> Signed-off-by: Alexander Gordeev <agordeev@...hat.com>
> ---
>  drivers/crypto/qat/qat_dh895xcc/adf_isr.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/qat/qat_dh895xcc/adf_isr.c b/drivers/crypto/qat/qat_dh895xcc/adf_isr.c
> index d4172de..1082e3b 100644
> --- a/drivers/crypto/qat/qat_dh895xcc/adf_isr.c
> +++ b/drivers/crypto/qat/qat_dh895xcc/adf_isr.c
> @@ -70,9 +70,9 @@ static int adf_enable_msix(struct adf_accel_dev *accel_dev)
>  	for (i = 0; i < msix_num_entries; i++)
>  		pci_dev_info->msix_entries.entries[i].entry = i;
>  
> -	if (pci_enable_msix(pci_dev_info->pci_dev,
> -			    pci_dev_info->msix_entries.entries,
> -			    msix_num_entries)) {
> +	if (pci_enable_msix_exact(pci_dev_info->pci_dev,
> +				  pci_dev_info->msix_entries.entries,
> +				  msix_num_entries)) {
>  		pr_err("QAT: Failed to enable MSIX IRQ\n");
>  		return -EFAULT;
>  	}
> -- 
> 1.9.3
> 

-- 
Regards,
Alexander Gordeev
agordeev@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/