linux-kernel - Re: [PATCH] mmc:sdhci: handle busy-end interrupt during command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 29 Aug 2014 13:18:42 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Chanho Min <chanho.min@....com>
Cc:	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Hankyung Yu <hankyung.yu@....com>,
	Gwendal Grignou <gwendal@...omium.org>
Subject: Re: [PATCH] mmc:sdhci: handle busy-end interrupt during command

On 21 August 2014 09:26, Ulf Hansson <ulf.hansson@...aro.org> wrote:
> On 21 August 2014 03:53, Chanho Min <chanho.min@....com> wrote:
>> It is fully legal for a controller to start handling busy-end interrupt
>> before it has signaled that the command has completed. So make sure
>> we do things in the proper order, Or it results that command interrupt
>> is ignored so it can cause unexpected operations. This is founded at some
>> toshiba emmc with the bellow warning.
>>
>> "mmc0: Got command interrupt 0x00000001 even though
>> no command operation was in progress."
>>
>> This issue has been also reported by Youssef TRIKI:
>> It is not specific to Toshiba devices, and happens with eMMC devices
>> as well as SD card which support Auto-CMD12 rather than CMD23.
>>
>> Also, similar patch is submitted by:
>> Gwendal Grignou <gwendal@...omium.org>
>>
>> Signed-off-by: Hankyung Yu <hankyung.yu@....com>
>> Signed-off-by: Chanho Min <chanho.min@....com>
>> Tested-by: Youssef TRIKI <youssef.triki@...com>
>
> Hi Chanho,
>
> This patch has been around for quite some time, sorry for lack of
> response. Appreciate if we could get this tested on a few more
> variants of sdhci, I am not able to test myself.
>
> I plan to queue this for 3.18, unless someone objects soon.

Hi Chanho,

I was about to apply this one, but I am hitting a conflict. Even if
wasn't too hard for me to resolve it, I think it might need an extra
round of testing. Could you please re-spin and send a new version?

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/