linux-kernel - Re: [PATCH 3/4] mfd: imanager2: Add Core supports for IT8516/18/28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140829112326.GL24579@lee--X1>
Date:	Fri, 29 Aug 2014 12:23:26 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Wei-Chun Pan <weichun.pan@...antech.com.tw>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Jean Delvare <jdelvare@...e.de>,
	Guenter Roeck <linux@...ck-us.net>,
	Wolfram Sang <wsa@...-dreams.de>,
	"Louis.Lu" <Louis.Lu@...antech.com.tw>,
	"Neo.Lo" <neo.lo@...antech.com.tw>,
	"Hank.Peng" <Hank.Peng@...antech.com.tw>,
	"Kevin.Ong" <Kevin.Ong@...antech.com.tw>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] mfd: imanager2: Add Core supports for IT8516/18/28

On Tue, 19 Aug 2014, Wei-Chun Pan wrote:

> > You've replied to this email as an independent message, so now there is little
> > context.  When you reply, please ensure your mailer replies to the thread.
> > 
> 
> Could you tell me more detail about this?
> I use Git to reply mails but don't know how to set them to be dependent on.

How do you use Git to reply to emails?

> > On Thu, 07 Aug 2014, Wei-Chun Pan wrote:
> > > I have a question for your comment. As your mail,
> > >
> > > > > +
> > > > > +static void __exit imanager2_mfd_device_exit(void) {
> > > > > +	mfd_remove_devices(&ec_pdev->dev);
> > > > > +	platform_device_unregister(ec_pdev);
> > > > > +}
> > > > > +
> > > > > +module_init(imanager2_mfd_device_init);
> > > > > +module_exit(imanager2_mfd_device_exit);
> > > >
> > > > This is a mess.  Use module_platform_driver() instead.
> > > >
> > > > > +MODULE_AUTHOR("Richard Vidal-Dorsch <richard.dorsch at
> > > > > +advantech.com>");
> > > > > +MODULE_DESCRIPTION("iManager2 platform device definitions v"
> > > > > +DRV_VERSION); MODULE_LICENSE("GPL");
> > MODULE_VERSION(DRV_VERSION);
> > > >
> > >
> > > How can I use module_platform_driver() and my driver exit function
> > > also can do mfd_remove_devices().
> > > Or any other better function install of mfd_remove_devices()?
> > 
> > That's the point - you don't do mfd_remove_devices() in exit(), you do
> > mfd_add_devices() in .probe() and mfd_remove_devices() in .remove().
> > 
> > The only thing you want to do in init() is platform_driver_register(), or even better
> > - don't have init() and exit() calls and use use
> > module_platform_driver_probe() instead.
> > 
> 
> It seems that module_platform_driver() only registers/unregisters driver but not device.
> Is there a method to register/unregister my device?

You need to do that from Device Tree or from within arch/<arch>/{mach,plat}-*

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/