linux-kernel - Re: [PATCH 1/1] USB: Add device quirk for ASUS T100 Base Station keyboard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54006B0A.2050902@cogentembedded.com>
Date:	Fri, 29 Aug 2014 15:59:06 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Lu Baolu <baolu.lu@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Mathias Nyman <mathias.nyman@...el.com>
CC:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] USB: Add device quirk for ASUS T100 Base Station
 keyboard

Hello.

On 8/29/2014 8:26 AM, Lu Baolu wrote:

> This full-speed USB device generates spurious remote wakeup event
> as soon as USB_DEVICE_REMOTE_WAKEUP feature is set. As the result,
> Linux can't enter system suspend and S0ix power saving modes once
> this keyboard is used.

> This patch tries to introduce USB_QUIRK_IGNOR_REMOTE_WAKEUP quirk.

    Why not IGNORE? This doesn't look like a big save...

> With this quirk set, wakeup capability will be ignored during
> device configure.

> This patch could be back-ported to kernels as old as 2.6.39.

> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/