linux-kernel - Re: [PATCH net v4 4/4] tg3: Fix tx_pending checks for tg3_tso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140829172045.GA1245@f1.synalogic.ca>
Date:	Fri, 29 Aug 2014 10:20:45 -0700
From:	Benjamin Poirier <bpoirier@...e.de>
To:	Prashant Sreedharan <prashant@...adcom.com>
Cc:	Michael Chan <mchan@...adcom.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v4 4/4] tg3: Fix tx_pending checks for tg3_tso_bug

On 2014/08/28 20:24, Prashant Sreedharan wrote:
> >  
> > -	for (i = 0; i < tp->irq_max; i++)
> > -		tp->napi[i].tx_pending = ering->tx_pending;
> > +	dev->gso_max_segs = TG3_TX_SEG_PER_DESC(ering->tx_pending - 1);
> > +	for (i = 0; i < tp->irq_max; i++) {
> > +		struct tg3_napi *tnapi = &tp->napi[i];
> > +
> > +		tnapi->tx_pending = ering->tx_pending;
> > +		if (netif_tx_queue_stopped(netdev_get_tx_queue(dev, i)) &&
> 
> Need to limit the number of TX queues to tp->txq_cnt instead of
> tp->irq_max as txq_cnt can be less than irq_max.
> 
> netif_set_real_num_tx_queues(tp->dev, tp->txq_cnt);

Thanks for your careful review, I'll resubmit shortly.

> 
> > +		    tnapi->wakeup_thresh >= ering->tx_pending)
> > +			tnapi->wakeup_thresh = MAX_SKB_FRAGS + 1;
> > +	}
> >  
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/