linux-kernel - Re: [PATCH 2/3] Fix a bidirectional UDS connect check typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5400B637.1060303@schaufler-ca.com>
Date:	Fri, 29 Aug 2014 10:19:51 -0700
From:	Casey Schaufler <casey@...aufler-ca.com>
To:	Lukasz Pawelczyk <l.pawelczyk@...sung.com>, r.krypa@...sung.com,
	havner@...il.com, m.lis@...sung.com,
	"Serge E. Hallyn" <serge@...lyn.com>,
	James Morris <james.l.morris@...cle.com>,
	linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org
CC:	Casey Schaufler <casey@...aufler-ca.com>
Subject: Re: [PATCH 2/3] Fix a bidirectional UDS connect check typo

On 8/29/2014 8:02 AM, Lukasz Pawelczyk wrote:
> The 54e70ec5eb090193b03e69d551fa6771a5a217c4 commit introduced a
> bidirectional check that should have checked for mutual WRITE access
> between two labels. Due to a typo the second check was incorrect.
>
> Signed-off-by: Lukasz Pawelczyk <l.pawelczyk@...sung.com>

Applied to git://git.gitorious.org/smack-next/kernel.git#smack-for-3.18

> ---
>  security/smack/smack_lsm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 478d99e..00443a9 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -3302,8 +3302,8 @@ static int smack_unix_stream_connect(struct sock *sock,
>  		rc = smk_bu_note("UDS connect", skp, okp->smk_known,
>  					MAY_WRITE, rc);
>  		if (rc == 0) {
> -			rc = smk_access(okp, okp->smk_known, MAY_WRITE, NULL);
> -			rc = smk_bu_note("UDS connect", okp, okp->smk_known,
> +			rc = smk_access(okp, skp->smk_known, MAY_WRITE, NULL);
> +			rc = smk_bu_note("UDS connect", okp, skp->smk_known,
>  						MAY_WRITE, rc);
>  		}
>  	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/